search

bbolker / bbmle

maximum likelihood estimation package
GNU General Public License v3.0
25 stars 13 forks source link

Class "summary.mle2" is not exported [feature request] #10

Closed andrechalom closed 7 years ago

andrechalom commented 7 years ago

Background:

I am the developer of a package that extends bbmle classes, and we're having some problems to extend the "summary.mle2" class.

The following class is working as intended:

setClass("fitsad", representation("mle2", sad="character", distr="character", trunc="numeric"))

But the following class definition makes devtools::document() crash, as it can't find "summary.mle2":

setClass("summary.sads", representation("summary.mle2", fixed="numeric"))

Request:

Would it be possible for bbmle to export the "summary.mle2" class? I think this might be beneficial for other heavy users of the package, and I see no obvious drawbacks.

bbolker commented 7 years ago

I made this change in the development version already (9856e75de413). I don't have definite plans for a new CRAN release, but could certainly try to do it sooner if your package needs it ...

andrechalom commented 7 years ago

Thanks a lot! I'm submitting a couple more issues on bbmle, all of them have very simple fixes. If they can all make it to bbmle version 1.0.20, this would be a great help for our package and for https://github.com/MoBiodiv/mobsim, which depends on sads.

andrechalom commented 7 years ago

Hi! Do you have an ETA for releasing a new version? I can help with code / testing / documentation if anything is needed. Thanks for your time!

bbolker commented 7 years ago

No reason not to submit to CRAN as soon as testing is done. I'll set up a release-critical issues list to work on.