search

bbolker / bbmle

maximum likelihood estimation package
GNU General Public License v3.0
25 stars 13 forks source link

Save start and fixed as part of call #18

Closed stouffer closed 6 years ago

stouffer commented 6 years ago

Currently, neither the start nor fixed variables are maintained as part of a fit. This can lead to problems later on since they may be variables that are not part of the environment to which the fit is returned. For example, fixed is needed in order to run profile/proffun and confint.

Following the process by which other variables (e.g., call$data, call$upper, call$lower, etc) are stored, it seems reasonable that start be maintained in full as call$start and that fixed be maintained in full as call$fixed.

bbolker commented 6 years ago

thanks! It occurs to me to wonder about adding a regression test, but this seems pretty straightforward ...

bbolker commented 4 years ago

Would you like to be included as a contributor in the next release? If so, please let me know what name to use.

stouffer commented 4 years ago

It wasn't a very groundbreaking addition, so I'm not really sure I "deserve" to be included. You're likely the better arbiter of such decisions.

If you think I should, my name is Daniel Stouffer.