search

bbolker / bbmle

maximum likelihood estimation package
GNU General Public License v3.0
25 stars 13 forks source link

Use of "representation" is deprecated in R 3.0.0 #9

Closed andrechalom closed 7 years ago

andrechalom commented 7 years ago

From setClass help page,

representation, access, version, S3methods : All these arguments are deprecated from version 3.0.0 of R and should be avoided. ‘representation’ is an argument inherited from S that included both ‘slots’ and ‘contains’, but the use of the latter two arguments is clearer and recommended.

bbolker commented 7 years ago

I'll change this, but ... this code was copied from R's stats4 package more than 10 years ago, and ironically the internal code in the (core) R package still uses representation: https://github.com/wch/r-source/blob/trunk/src/library/stats4/R/mle.R#L19

andrechalom commented 7 years ago

It seems like a simple fix. Let me know if I can submit a Pull Request.

bbolker commented 7 years ago

fixed already ...