bbolker / broom.mixed

tidy methods for mixed models in R
227 stars 23 forks source link

augment method not working for `nlme`/`lme` objects #58

Closed IndrajeetPatil closed 5 years ago

IndrajeetPatil commented 5 years ago
# data
library(nlme)
set.seed(123)
startvec <- c(Asym = 200, xmid = 725,scal = 350)

# model
nm1 <- nlme(circumference ~ SSlogis(age, Asym, xmid, scal),
            data = Orange,
            fixed = Asym + xmid + scal ~ 1,
            random = Asym ~ 1,
            start = startvec)

# not supposed to work
broom.mixed::augment(nm1)
#> Error in augment.lme(nm1): augment.lme must be called with an explicit 'data' argument for this (n)lme fit  because of an inconsistency in nlme.

# supposed to work
broom.mixed::augment(nm1, data = startvec)
#> Warning in seq_len(nrow(x)): first element used of 'length.out' argument
#> Error in seq_len(nrow(x)): argument must be coercible to non-negative integer

#> traceback()
4: fix_data_frame(original, newcol = ".rownames")
3: augment_columns(x, data, newdata, se.fit = NULL)
2: augment.lme(nm1, data = startvec)
1: broom.mixed::augment(nm1, data = startvec)

Created on 2019-02-10 by the reprex package (v0.2.1)

Session info ``` r devtools::session_info() #> - Session info ---------------------------------------------------------- #> setting value #> version R Under development (unstable) (2018-11-30 r75724) #> os Windows 10 x64 #> system x86_64, mingw32 #> ui RTerm #> language (EN) #> collate English_United States.1252 #> ctype English_United States.1252 #> tz America/New_York #> date 2019-02-10 #> #> - Packages -------------------------------------------------------------- #> package * version date lib #> assertthat 0.2.0 2017-04-11 [1] #> backports 1.1.3 2018-12-14 [1] #> broom 0.5.1.9000 2019-01-20 [1] #> broom.mixed 0.2.3.9000 2019-01-23 [1] #> callr 3.1.1 2018-12-21 [1] #> cli 1.0.1.9000 2019-01-20 [1] #> coda 0.19-2 2018-10-08 [1] #> crayon 1.3.4 2017-09-16 [1] #> desc 1.2.0 2019-01-21 [1] #> devtools 2.0.1.9000 2019-01-29 [1] #> digest 0.6.18 2018-10-10 [1] #> dplyr 0.8.0 2019-02-06 [1] #> evaluate 0.12 2018-10-09 [1] #> fs 1.2.6 2018-08-23 [1] #> generics 0.0.2 2019-01-20 [1] #> glue 1.3.0 2018-07-17 [1] #> highr 0.7 2018-06-09 [1] #> htmltools 0.3.6 2017-04-28 [1] #> knitr 1.21 2018-12-10 [1] #> lattice 0.20-38 2018-11-04 [2] #> magrittr 1.5 2014-11-22 [1] #> Matrix 1.2-15 2018-11-01 [1] #> memoise 1.1.0 2017-04-21 [1] #> nlme * 3.1-137 2018-04-07 [2] #> pillar 1.3.1 2018-12-15 [1] #> pkgbuild 1.0.2 2018-10-16 [1] #> pkgconfig 2.0.2 2018-08-16 [1] #> pkgload 1.0.2 2018-10-29 [1] #> plyr 1.8.4 2016-06-08 [1] #> prettyunits 1.0.2 2015-07-13 [1] #> processx 3.2.1 2018-12-05 [1] #> ps 1.3.0 2018-12-21 [1] #> purrr 0.3.0 2019-01-27 [1] #> R6 2.3.0 2018-10-04 [1] #> Rcpp 1.0.0 2018-11-07 [1] #> remotes 2.0.2 2018-10-30 [1] #> reshape2 1.4.3 2017-12-11 [1] #> rlang 0.3.1 2019-01-08 [1] #> rmarkdown 1.11 2018-12-08 [1] #> rprojroot 1.3-2 2018-01-03 [1] #> sessioninfo 1.1.1 2018-11-05 [1] #> stringi 1.2.4 2018-07-20 [1] #> stringr 1.4.0 2019-02-10 [1] #> testthat 2.0.1 2018-10-13 [1] #> tibble 2.0.1 2019-01-12 [1] #> tidyr 0.8.2 2018-10-28 [1] #> tidyselect 0.2.5 2018-10-11 [1] #> TMB 1.7.15 2018-11-09 [1] #> usethis 1.4.0.9000 2019-02-11 [1] #> withr 2.1.2 2018-03-15 [1] #> xfun 0.4 2018-10-23 [1] #> yaml 2.2.0 2018-07-25 [1] #> source #> CRAN (R 3.5.1) #> CRAN (R 3.6.0) #> Github (tidymodels/broom@66411c4) #> Github (bbolker/broom.mixed@fbe9597) #> CRAN (R 3.6.0) #> Github (r-lib/cli@94e2fc5) #> CRAN (R 3.5.1) #> CRAN (R 3.5.1) #> Github (r-lib/desc@42b9578) #> Github (r-lib/devtools@e4e57aa) #> CRAN (R 3.5.1) #> Github (tidyverse/dplyr@cf0e282) #> CRAN (R 3.5.1) #> CRAN (R 3.5.1) #> Github (r-lib/generics@d59e6b4) #> CRAN (R 3.5.1) #> CRAN (R 3.5.1) #> CRAN (R 3.5.1) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> CRAN (R 3.5.1) #> CRAN (R 3.5.1) #> CRAN (R 3.5.1) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> CRAN (R 3.5.1) #> CRAN (R 3.5.1) #> CRAN (R 3.6.0) #> CRAN (R 3.5.1) #> CRAN (R 3.5.1) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> CRAN (R 3.5.2) #> CRAN (R 3.5.1) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> CRAN (R 3.5.1) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> CRAN (R 3.5.1) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> CRAN (R 3.5.1) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> CRAN (R 3.5.1) #> CRAN (R 3.6.0) #> Github (r-lib/usethis@8e3c151) #> CRAN (R 3.5.1) #> CRAN (R 3.6.0) #> CRAN (R 3.5.1) #> #> [1] C:/Users/inp099/Documents/R/win-library/3.6 #> [2] C:/Program Files/R/R-devel/library ```
bbolker commented 5 years ago

Is this a thinko, or is there something I'm missing? Why are you using data = startvec ? broom.mixed::augment(nm1, data = Orange) is what I would have expected, and works fine ...

IndrajeetPatil commented 5 years ago

Argh, you are right, didn't think this one through.