search

bbolker / broom.mixed

tidy methods for mixed models in R
227 stars 23 forks source link

`gamlss` present in both `broom` and `broom.mixed` #64

Closed IndrajeetPatil closed 3 years ago

IndrajeetPatil commented 5 years ago

@alexpghayes and @bbolker: The development version of broom has gotten rid of all the shared S3 methods between these two packages except for one: gamlss.

What's the future of this tidier? broom or broom.mixed? This is especially important because broom.mixed has changed this tidier since it separated from broom, while the latter hasn't changed. This means tidy() will return results based on whatever method is currently loaded.

alexpghayes commented 5 years ago

It makes sense for the gamlss and gam (and Gam) tidiers to stick together. There's also https://github.com/tidymodels/broom/issues/596 discussing how to implement tidiers for GAMMs. I think these tidiers could arguably belong in:

bbolker commented 5 years ago

I don't have strong feelings.

IndrajeetPatil commented 5 years ago

I have opened a PR at broom (https://github.com/tidymodels/broom/pull/653) that brings the gamlss tidier up to speed with changes made to the same tidier in broom.mixed.

alexpghayes commented 5 years ago

Let's keep tidy.gamlss() in broom then. Will merge that in when I get a moment.

bbolker commented 3 years ago

https://github.com/tidymodels/broom/issues/507