search

bbolker / broom.mixed

tidy methods for mixed models in R
229 stars 23 forks source link

consistent column naming for `wblm` objects from `panelr` #76

Closed IndrajeetPatil closed 5 years ago

IndrajeetPatil commented 5 years ago

All other glance methods return AIC and BIC columns, while this particular one returns aic and bic.

# setup
set.seed(123)
library(panelr)
#> Loading required package: lme4
#> Loading required package: Matrix
#> 
#> Attaching package: 'panelr'
#> The following object is masked from 'package:stats':
#> 
#>     filter
data("WageData")
wages <- panel_data(WageData, id = id, wave = t)

# model
m1 <-
  wbm(lwage ~ lag(union) + wks | blk + fem | blk * lag(union), data = wages)

# glance
broom.mixed::glance(m1)
#> Registered S3 method overwritten by 'broom.mixed':
#>   method      from 
#>   tidy.gamlss broom
#> # A tibble: 1 x 8
#>   min_wave max_wave     N   aic   bic pR2_fe pR2_total model         
#>      <dbl>    <dbl> <dbl> <dbl> <dbl>  <dbl>     <dbl> <chr>         
#> 1        2        7   595 1386. 1448.  0.132     0.738 within-between

Created on 2019-08-18 by the reprex package (v0.3.0)

Session info ``` r devtools::session_info() #> - Session info ---------------------------------------------------------- #> setting value #> version R version 3.6.1 (2019-07-05) #> os Windows 10 x64 #> system x86_64, mingw32 #> ui RTerm #> language (EN) #> collate English_United States.1252 #> ctype English_United States.1252 #> tz America/New_York #> date 2019-08-18 #> #> - Packages -------------------------------------------------------------- #> package * version date lib #> assertthat 0.2.1 2019-03-21 [1] #> backports 1.1.4 2019-04-10 [1] #> boot 1.3-23 2019-07-05 [1] #> broom 0.5.2.9002 2019-08-15 [1] #> broom.mixed 0.2.4.9000 2019-08-07 [1] #> callr 3.3.1 2019-07-18 [1] #> cli 1.1.0 2019-03-19 [1] #> coda 0.19-3 2019-07-05 [1] #> colorspace 1.4-1 2019-03-18 [1] #> crayon 1.3.4 2017-09-16 [1] #> desc 1.2.0 2019-04-03 [1] #> devtools 2.1.0 2019-07-06 [1] #> digest 0.6.20 2019-07-04 [1] #> dplyr 0.8.3 2019-07-04 [1] #> evaluate 0.14 2019-05-28 [1] #> fansi 0.4.0 2018-11-05 [1] #> Formula 1.2-3 2018-05-03 [1] #> fs 1.3.1 2019-05-06 [1] #> generics 0.0.2 2019-03-05 [1] #> ggplot2 3.2.1 2019-08-10 [1] #> glue 1.3.1 2019-03-12 [1] #> gtable 0.3.0 2019-03-25 [1] #> highr 0.8 2019-03-20 [1] #> htmltools 0.3.6 2017-04-28 [1] #> jtools 2.0.1 2019-04-08 [1] #> knitr 1.24 2019-08-08 [1] #> lattice 0.20-38 2018-11-04 [2] #> lazyeval 0.2.2 2019-03-15 [1] #> lifecycle 0.1.0 2019-08-01 [1] #> lme4 * 1.1-21 2019-03-05 [1] #> lmerTest 3.1-0 2019-02-11 [1] #> magrittr 1.5 2014-11-22 [1] #> MASS 7.3-51.4 2019-03-31 [1] #> Matrix * 1.2-17 2019-03-22 [1] #> memoise 1.1.0 2017-04-21 [1] #> minqa 1.2.4 2014-10-09 [1] #> munsell 0.5.0 2018-06-12 [1] #> nlme 3.1-140 2019-05-12 [2] #> nloptr 1.2.1 2018-10-03 [1] #> numDeriv 2016.8-1.1 2019-06-06 [1] #> pander 0.6.3 2018-11-06 [1] #> panelr * 0.7.1 2019-07-12 [1] #> pillar 1.4.2 2019-06-29 [1] #> pkgbuild 1.0.4 2019-08-05 [1] #> pkgconfig 2.0.2 2018-08-16 [1] #> pkgload 1.0.2 2018-10-29 [1] #> plyr 1.8.4 2016-06-08 [1] #> prettyunits 1.0.2 2015-07-13 [1] #> processx 3.4.1 2019-07-18 [1] #> ps 1.3.0 2018-12-21 [1] #> purrr 0.3.2 2019-03-15 [1] #> R6 2.4.0 2019-02-14 [1] #> Rcpp 1.0.2 2019-07-25 [1] #> remotes 2.1.0 2019-06-24 [1] #> reshape2 1.4.3 2017-12-11 [1] #> rlang 0.4.0 2019-06-25 [1] #> rmarkdown 1.14.3 2019-08-02 [1] #> rprojroot 1.3-2 2018-01-03 [1] #> scales 1.0.0 2018-08-09 [1] #> sessioninfo 1.1.1 2018-11-05 [1] #> stringi 1.4.3 2019-03-12 [1] #> stringr 1.4.0 2019-02-10 [1] #> testthat 2.2.1 2019-07-25 [1] #> tibble 2.1.3 2019-06-06 [1] #> tidyr 0.8.99.9000 2019-08-11 [1] #> tidyselect 0.2.5 2018-10-11 [1] #> TMB 1.7.15 2018-11-09 [1] #> usethis 1.5.1.9000 2019-07-27 [1] #> utf8 1.1.4 2018-05-24 [1] #> vctrs 0.2.0 2019-07-05 [1] #> withr 2.1.2 2018-03-15 [1] #> xfun 0.8 2019-06-25 [1] #> yaml 2.2.0 2018-07-25 [1] #> zeallot 0.1.0 2018-01-28 [1] #> source #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> CRAN (R 3.6.1) #> local #> Github (bbolker/broom.mixed@46f79ec) #> CRAN (R 3.6.1) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> CRAN (R 3.5.1) #> Github (r-lib/desc@c860e7b) #> CRAN (R 3.6.1) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> Github (brodieG/fansi@ab11e9c) #> CRAN (R 3.5.0) #> CRAN (R 3.6.0) #> Github (r-lib/generics@c15ac43) #> CRAN (R 3.6.1) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> CRAN (R 3.5.1) #> CRAN (R 3.6.0) #> CRAN (R 3.6.1) #> CRAN (R 3.6.1) #> CRAN (R 3.6.0) #> CRAN (R 3.6.1) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> CRAN (R 3.5.1) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> CRAN (R 3.5.1) #> CRAN (R 3.5.1) #> CRAN (R 3.6.1) #> CRAN (R 3.5.1) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> CRAN (R 3.6.1) #> CRAN (R 3.6.0) #> CRAN (R 3.6.1) #> CRAN (R 3.5.1) #> CRAN (R 3.6.0) #> CRAN (R 3.5.1) #> CRAN (R 3.5.1) #> CRAN (R 3.6.1) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> CRAN (R 3.6.1) #> CRAN (R 3.6.0) #> CRAN (R 3.5.1) #> CRAN (R 3.6.0) #> Github (rstudio/rmarkdown@37bcb8f) #> CRAN (R 3.5.1) #> CRAN (R 3.5.1) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> CRAN (R 3.6.0) #> CRAN (R 3.6.1) #> CRAN (R 3.6.0) #> Github (tidyverse/tidyr@908da2c) #> CRAN (R 3.5.1) #> CRAN (R 3.6.0) #> Github (r-lib/usethis@b241420) #> CRAN (R 3.5.1) #> CRAN (R 3.6.1) #> CRAN (R 3.5.1) #> CRAN (R 3.6.0) #> CRAN (R 3.5.1) #> CRAN (R 3.5.1) #> #> [1] C:/Users/inp099/Documents/R/win-library/3.6 #> [2] C:/Program Files/R/R-3.6.1/library ```
bbolker commented 5 years ago

Thanks for the report ... but ... since this method appears to be implemented in the panelr package (not in broom.mixed), the issue should probably be posted on panelr's GitHub issues list instead ...

> class(m1)
"wblm"
> is (m1,"wmb")
TRUE   
> getAnywhere("glance.wbm")
A single object matching ‘glance.wbm’ was found
It was found in the following places
  registered S3 method for glance from namespace panelr
  namespace:panelr
with value

function (x, ...) 
{
    sum <- summary(x)
    mod_info_list <- sum$mod_info_list
    mod_info_list[sapply(mod_info_list, is.null)] <- NA
    return(tibble::as_tibble(mod_info_list))
}
<bytecode: 0xaec28e8>
<environment: namespace:panelr>