search

bbolker / broom.mixed

tidy methods for mixed models in R
227 stars 23 forks source link

add orcid; style code; remove spelling errors #84

Closed IndrajeetPatil closed 4 years ago

IndrajeetPatil commented 4 years ago

Btw, one thing I noticed when I cloned the repo was that the size of the folder is 123MB!

Do you know why that might be?

bbolker commented 4 years ago

I'm sorry to be a pain about this, but I would strongly prefer at least the code style changes to be in a separate commit. (What code style did you use, and how did you execute it [e.g. editor, styler package, ...)

bbolker commented 4 years ago

I suspect that the large size of the repo has to do with the stored fitted-modelobjects that I use for testing. The fitted-model objects produced by Stan-based methods (rstanarm, brms, etc.) are very large; it took me several tries to figure out how to minimize their storage space, and it's quite possible that some of the unsuccessful attempts are stored in the repo history.

IndrajeetPatil commented 4 years ago

I'm sorry to be a pain about this, but I would strongly prefer at least the code style changes to be in a separate commit. (What code style did you use, and how did you execute it [e.g. editor, styler package, ...)

I am using tidyverse style guide, which is what broom uses as well so it will good to be consistent with it. I will try to make a separate PR soon.

bbolker commented 4 years ago

thanks! Did you use styler?

IndrajeetPatil commented 4 years ago

Yes, styler::style_pkg()