search

bbolli / tumblr-utils

Utilities for dealing with Tumblr blogs, Tumblr backup
GNU General Public License v3.0
668 stars 124 forks source link

Necessity of editing $PATH #103

Closed ReGuess closed 4 years ago

ReGuess commented 6 years ago

Is it really necessary for users – especially Windows users – to edit their $PATH variables? The Windows operating system checks the current working directory before it checks %PATH%, and the beginner's instructions tell the user how to cd to the right directory before running tumblr_backup.py, so it seems like having the user edit %PATH% creates an unnecessary security risk.

bbolli commented 6 years ago

What's the risk exactly? Other tools add their install folder to the PATH all the time.

But feel free to send a pull request to remove the offending instructions.

ReGuess commented 6 years ago

https://security.stackexchange.com/questions/143288/some-folders-in-the-path-variable-are-writable-by-anyone-dangerous-or-not

cebtenzzre commented 4 years ago

Editing PATH is a normal thing for a user to do. It can only affect the behavior of poorly written programs or the command line.