search

bbolli / tumblr-utils

Utilities for dealing with Tumblr blogs, Tumblr backup
GNU General Public License v3.0
668 stars 124 forks source link

Embedded movies don't get downloaded even with --save-video #172

Closed humanitiesclinic closed 4 years ago

humanitiesclinic commented 5 years ago

Even with youtube_dl, and the --save-video option enabled, I have some posts where Instagram and youtube movies are embedded in the original, but they are not downloaded. My other videos are downloaded. Is it possible with the current version of the script to download Instagram and Youtube, and other movies? If yes, what command line option should I use?

Btw, the error message that I get from the .py script is: Unable to download video in post #....

cebtenzzre commented 5 years ago

Please provide a few more full lines of output, if possible. It's fine if you'd like to redact certain information, but it would help greatly if you could either provide a link to a post that has a video that does not get downloaded, or at least a section of the JSON for such a post (using the -j option).

aspensmonster commented 5 years ago

Pretty sure I've got a few of these in my archive. One example json payload is attached. is_blocks_post_format is false, the type is text, and there is an embedded video in what looks like NPF format. So perhaps NPF posts aren't always going to have is_blocks_post_format set to true?

aspensmonster commented 5 years ago

Or not... I can't even edit that post anymore after trying to drag-and-drop attach. In any event, the payload is here:

https://pastebin.com/zsXXNNP1

Edit:

(apparently there's a new github domain (githubassets.com) which NoScript was blocking; maybe that's what broke the drag-and-drop?; anyway...)

And another (this one from testingvideoz test tumblr made, probably relates to this commit comment):

https://pastebin.com/wgZPzjXb

I'm currently fiddling with an approach to try and detect this scenario and properly archive it.

cebtenzzre commented 4 years ago

This should be fixed by 55b8301e212463ffb21db19532d745a4014c27fa.