search

bbondy / codefirefox

Video and exercise based tutorial site for coding Firefox and other Mozilla related technology
http://codefirefox.com
GNU General Public License v2.0
67 stars 18 forks source link

urlbar: red no longer actually shows the url background as red #244

Open markjszy opened 10 years ago

markjszy commented 10 years ago

I spent some time trying a few different builds to show this change mentioned on this video (http://codefirefox.com/video/incremental-builds) but to no avail.

putting #background-color: red at the top of browser.css as advised does not show visible changes in the latest firefox builds.

I spent some time on IRC working through this and at least one other user with more experience (capella) confirmed that this sort of patch does not actually have an obvious effect.

bbondy commented 10 years ago

Thanks for the report and sorry you ran into this! This is due to some changes that make the suggested change no longer work.

I updated the page with a different work around right now in the comments. And I put a description on the video pointing to the comments.

http://codefirefox.com/video/incremental-builds

I'll leave this bug open to re-record to use popcorn.js to overlay a different change.