search

bbonnin / pulsar-express

Simple Web Interface for Apache Pulsar
Apache License 2.0
111 stars 20 forks source link

Updates to run Pulsar Express inside k8s cluster #22

Closed cdbartholomew closed 4 years ago

cdbartholomew commented 4 years ago

Hi Bruno,

We really like Pulsar Express and we just added the option to install it as part of the Kubernetes Helm chart that we maintain for Pulsar: https://github.com/kafkaesque-io/pulsar-helm-chart. We hope that you have no objection to that.

To get Pulsar Express to work running inside the cluster with standalone function workers, we had to make some small changes, mostly to workaround issues with REST calls to the function worker API. We also had to add token authentication to the health check function, since it wasn't working in clusters with authentication enabled.

Since we are configuring the connection automatically using environment variables, and you are likely to only use Pulsar Express to manage the Pulsar it is co-located with, we enhanced the Cluster selectors to default to the first cluster they find for convenience in the installed-with-Pulsar case.

We have tested these changes against standalone instances of Pulsar as well, so we believe that they will not regress the standalone use case.

Anyway, we hope that you find these changes useful for the project.

Cheers, Chris

brunobonnin commented 4 years ago

Hi Chris, Thanks a lot for your PR !!