Flot instance never updates

bbooth / ember-cli-flot

Add flot charts to an ember-cli application

MIT License

5 stars 3 forks source link

Flot instance never updates #5

Open barneycarroll opened 8 years ago

barneycarroll commented 8 years ago

The core setupFlotChart method is scheduled for execution on dataChanged and optionsChanged lifecycle events, but these don't seem to be referenced anywhere else in the codebase.

Shouldn't this be didUpdateAttrs, the canonical way to watch for a change in input?

stickbyatlas commented 7 years ago

Yes, it should, and thanks for pointing this out. You saved me a tonne of wasted time trying to figure out why my chart wasn't updating. The maintainer should merge your pull request.