search

bbopt / NOMAD.jl

Julia interface to the NOMAD blackbox optimization software
Other
47 stars 5 forks source link

New api and features #32

Closed salomonl closed 3 years ago

salomonl commented 3 years ago

This branch follows the C api simplification of Nomad:

codecov[bot] commented 3 years ago

Codecov Report

Merging #32 (f8d9f3f) into master (873c4de) will decrease coverage by 1.55%. The diff coverage is 93.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   96.29%   94.73%   -1.56%     
==========================================
  Files           4        4              
  Lines         243      266      +23     
==========================================
+ Hits          234      252      +18     
- Misses          9       14       +5
Impacted Files Coverage Δ
src/c_wrappers.jl 90.90% <88.23%> (-7.17%) :arrow_down:
src/core.jl 94.69% <95.55%> (-0.44%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 873c4de...f8d9f3f. Read the comment docs.

amontoison commented 3 years ago

I rebased your branch. I propose to merge this PR if all tests passed.

amontoison commented 3 years ago

@salomonl, three new features are not tested : https://github.com/bbopt/NOMAD.jl/pull/32/checks?check_run_id=1920004063 We can improve the code coverage with another PR.