Closed amontoison closed 3 years ago
Merging #37 (77e1735) into master (50c9e3a) will increase coverage by
0.30%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
+ Coverage 95.48% 95.78% +0.30%
==========================================
Files 4 4
Lines 266 285 +19
==========================================
+ Hits 254 273 +19
Misses 12 12
Impacted Files | Coverage Δ | |
---|---|---|
src/c_wrappers.jl | 91.66% <ø> (+0.75%) |
:arrow_up: |
src/core.jl | 96.58% <0.00%> (+0.12%) |
:arrow_up: |
src/converters.jl | 96.63% <0.00%> (+0.34%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 50c9e3a...77e1735. Read the comment docs.
It seems as a good idea. But the CInterfarce library is not located at the same folder as for the other. Have you tested it ?
No, I didn't test it. It's for that reason that I tagged you.
I have an old version of NOMAD that compiles the libraries libnomadAlgos.so
, libnomadEval.so
, libnomadInterface.so
, libnomadUtils.so
and libsgtelib.so
in the same folder .../NOMAD/build/lib
.
Sorry for the delay. I finally have found how to test the pull request locally.
You do not need to indicate the path for libnomadAlgos
, libnomadEval
, libnomadUtils
, libsgtelib
library paths (at least on my machine). They are linked to the libnomadCInterface
.
Maybe it could be a good idea to mention it in the documentation ?
@salomonl
I use the same trick with
qr_mumps
. It could be relevant for you when you want to add features to the C code / interface of NOMAD. What do you think about it ?