bbopt / NOMAD.jl

Julia interface to the NOMAD blackbox optimization software
Other
47 stars 5 forks source link

Bump nomad to 4.2 #60

Closed SobhanMP closed 1 year ago

SobhanMP commented 2 years ago

removes the deprecated options. should be merged after https://github.com/JuliaPackaging/Yggdrasil/pull/5182 and https://github.com/bbopt/NOMAD.jl/pull/59 are merged. Alternatively, merge this and close #59 w/o squashing. The binaries can be found https://github.com/SobhanMP/NOMAD_jll.jl

SobhanMP commented 2 years ago

the CI is going to fail because NOMAD_jll 4.2 is not available in the registery.

amontoison commented 1 year ago

@SobhanMP The main developer of NOMAD was not working the last three weeks (summer holidays) but it fixed the issue with MinGW compilation today! It will test if everything works fine tomorrow. We should be able to update the build_tarballs.jl after that.

SobhanMP commented 1 year ago

cool

codecov[bot] commented 1 year ago

Codecov Report

Merging #60 (bbb5c62) into master (04281ea) will increase coverage by 0.51%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   96.38%   96.90%   +0.51%     
==========================================
  Files           3        3              
  Lines         332      323       -9     
==========================================
- Hits          320      313       -7     
+ Misses         12       10       -2     
Impacted Files Coverage Δ
src/c_wrappers.jl 93.84% <100.00%> (+0.29%) :arrow_up:
src/core.jl 98.46% <100.00%> (+1.27%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

amontoison commented 1 year ago

@SobhanMP I can't merge the PR due to conflits. @solomonl Can you review the PR ?

SobhanMP commented 1 year ago

image what branch do you want to merge it to?

amontoison commented 1 year ago

Capture d’écran du 2022-08-19 00-39-05 I want to merge it to master :thinking:

SobhanMP commented 1 year ago

❯ git pull upstream master From https://github.com/bbopt/NOMAD.jl

maybe use the command line instructions?

amontoison commented 1 year ago

❯ git pull upstream master From https://github.com/bbopt/NOMAD.jl

  • branch master -> FETCH_HEAD Already up to date.

maybe use the command line instructions?

Did you try git rebase upstream/master ? The other option Squash and merge is available for me but I don't understand why I can't do Rebase and merge.

amontoison commented 1 year ago

Thanks @SobhanMP ! I did a squash + merge.