bbopt / nomad

NOMAD - A blackbox optimization software
https://nomad-4-user-guide.readthedocs.io/
GNU Lesser General Public License v3.0
114 stars 24 forks source link

Inconsistency in AllParameters::readParamLine #110

Closed jan-provaznik closed 1 year ago

jan-provaznik commented 1 year ago

The comment claims the function AllParameters::readParamLine throws for unknown parameters.

The implementation, however, does not throw anything. Instead, the errors are printed out to the standard error stream.

ctribes commented 1 year ago

The comment is changed for the next release.

Note that unrecognized parameters can trigger an exception or not (just a message) when doing RunParams::checkAndComply. This is managed by REJECT_UNKNOWN_PARAMETERS.

jan-provaznik commented 1 year ago

Thanks for the clarification and the fix.

ctribes commented 1 year ago

I am also changing the default value for REJECT_UNKNOWN_PARAMETERS in NOMAD 4.3 (now it is true instead of false) so that an exception is triggered for unregistered params.