Patch: move MeshBase to libnomadEval

bbopt / nomad

NOMAD - A blackbox optimization software

https://nomad-4-user-guide.readthedocs.io/

GNU Lesser General Public License v3.0

114 stars 24 forks source link

Patch: move MeshBase to libnomadEval #117

Closed ctribes closed 1 year ago

ctribes commented 1 year ago

MeshBase is used in EvalPoint (libnomadEval). Some compilers are more picky.

amontoison commented 1 year ago

For the issue with matrix.config.name, you just need to remove the white space in the name of windows builds. Windows -- MinGW -> Windows--MinGW.

amontoison commented 1 year ago

Christophe, can you also update this line: https://github.com/bbopt/nomad/blob/master/.github/workflows/ci.yml#L73 ?

I used the matrix.config.name to force the MinGW compiler and you removed the blanks. I also help CMake to find the MinGW compiler with the PR #118.