search

bborn / communityengine

Adds basic social networking capabilities to your existing application, including users, blogs, photos, clippings, favorites, and more.
http://www.communityengine.org
Other
1.14k stars 317 forks source link

Support higher version of ruby? #314

Closed taro-k closed 3 years ago

taro-k commented 8 years ago

README.markdown says:

Requirements:

but .travis.yml says rvm

Is it OK to use Ruby 2.3.1?

Related information: https://www.ruby-lang.org/en/downloads/ In security maintenance phase (will EOL soon!): Ruby 2.1.10 Not maintained anymore (EOL): Ruby 2.0.0-p648

taro-k commented 8 years ago

I treat this matter in my forked repo and close here. https://github.com/taro-k/communityengine/issues/1

taro-k commented 8 years ago

@t-bullock Hello. I found your commit https://github.com/bborn/communityengine/commit/28cada7491e1bc751ebdd0d47891090fbf038aa6 . Why did you re-add and set back to Ruby-2.0.0 which is already out of security fix?

t-bullock commented 8 years ago

I guess I didn't realize support for 2.0 had ended at that point. You can remove it.

taro-k commented 8 years ago

@t-bullock OK, thx, that's fine, but I think such drop should be done for the new branch after restructuring branches I suggested here: https://github.com/bborn/communityengine/pull/324