Closed ben-manes closed 5 years ago
This worked in v1.0.1 and v1.1.0, and broke in v1.1.1.
Whoa, weird. @bbottema -- thoughts?
I'll look into it asap.
Hey guys, I'm terribly sorry. I had cleaned up the code a bit for a fix I later reverted, but I left in the cleanup. Somehow I mixed up the argument order of the InternetAddress
constructor:
return new InternetAddress(parts[0], parts[1] + "@" + parts[2]);
// instead of:
return new InternetAddress(parts[1] + "@" + parts[2], parts[0]);
I guess I assumed the name came first (maybe because that's how it is in Simple Java Mail as well).
Anyway I fixed it and released 1.1.2.
Thanks for the speedy fix! Does this prompt a new release of simple-java-mail
since this is a transitive dependency?
Indeed, I just released 5.1.3! Thanks for the reminder ;)
Awesome, thanks!
results in
Bob
, not the expectedbob@hi.com
. This means if the personal name is not provided then the email isnull
, which is what caused my code to NPE unexpectedly :)