bbottema / email-rfc2822-validator

The world's only Java-based rfc2822-compliant email address validator and parser
64 stars 13 forks source link

IllegalArgumentException when passing null to EmailAddressValidator.isValid(String) #17

Closed PascalSchumacher closed 4 years ago

PascalSchumacher commented 4 years ago

After updating from 1.1.3 to 2.1.3 it is no longer possible to pass null to EmailAddressValidator.isValid(String):

java.lang.IllegalArgumentException: Implicit NotNull argument 0 of org/hazlewood/connor/bottema/emailaddress/EmailAddressValidator.isValid must not be null
    at org.hazlewood.connor.bottema.emailaddress.EmailAddressValidator.isValid(EmailAddressValidator.java)

I guess this is not intended because EmailAddressValidator.isValid(String, EnumSet<EmailAddressCriteria) still allows null for the first parameter, but isValid and isValidStrict do not.

bbottema commented 4 years ago

Fixed the issue, but OSS Sonatype is still having network issues. I can't release 2.1.4 right now.

PascalSchumacher commented 4 years ago

Thanks for the quick fix! 👍

bbottema commented 4 years ago

2.1.4 released!

PascalSchumacher commented 4 years ago

Thank you very much!