search

bbottema / email-rfc2822-validator

The world's only Java-based rfc2822-compliant email address validator and parser
64 stars 13 forks source link

Published JARs for versions 2.2.0 and 2.3.0 have an invalid module name in MANIFEST.MF #24

Closed anderswisch closed 1 year ago

anderswisch commented 1 year ago

Published JARs for versions 2.2.0 and 2.3.0 have an invalid module name in MANIFEST.MF.

Both contain this line:

Automatic-Module-Name: emailaddress-rfc2822

Because it contains a - character, it is not a valid identifier. Running jar --describe-module --file emailaddress-rfc2822-2.2.0.jar gives output:

Unable to derive module descriptor for: emailaddress-rfc2822-2.2.0.jar
Automatic-Module-Name: emailaddress-rfc2822: Invalid module name: 'emailaddress-rfc2822' is not a Java identifier
anderswisch commented 1 year ago

I think this comes from https://github.com/bbottema/standard-project-parent/blob/master/pom.xml#L60 (artifactId can contain dashes)

anderswisch commented 1 year ago

This problem also affects version 1.0.1 of https://github.com/bbottema/jetbrains-runtime-nullability-annotations

bbottema commented 1 year ago

Hmm, that's a problem. I'm not sure how to get the unique project name without dashes and I don't really have the time lately to do research. Any suggestions?

anderswisch commented 1 year ago

I put up a clumsy fix for this in https://github.com/bbottema/standard-project-parent/pull/10. Let me know what you think. It's been awhile since I tried to do this kind of thing in Maven.

bbottema commented 1 year ago

Fixed by https://github.com/bbottema/email-rfc2822-validator/commit/aea17f8b08638c5ee21e93f0f1335c6f52471d51

bbottema commented 1 year ago

Fix released in 2.3.1