bbottema / simple-java-mail

Simple API, Complex Emails (Jakarta Mail smtp wrapper)
http://www.simplejavamail.org
Apache License 2.0
1.22k stars 266 forks source link

Update to Angus Mail #489

Closed PascalSchumacher closed 8 months ago

PascalSchumacher commented 9 months ago

The Jakarata Mail implementation was renamed to Angus Mail. With Angus Mail 2 the package names where changed from com.sun.mail.* to org.eclipse.angus.mail.*.

It would be nice if simple-java-mail was updated to use the latest Angus Mail release.

By the way: Thank you very much for providing simple-java-mail!

vladimirfx commented 8 months ago

I can provide a PR if needed.

bbottema commented 8 months ago

It's not that easy. You'd have to upgrade all upstream projects as well, like the smtp connection pool library. I'll deal with it.

vladimirfx commented 8 months ago

OK. Now it is so painful to use SJM with the actual Spring Boot version. Thaks

bbottema commented 8 months ago

Upgrade released in 8.6.0.

PascalSchumacher commented 8 months ago

Thank you very much! 👍

Faelean commented 8 months ago

Looking at the dependency tree I've noticed one issue: With the renaming to Angus Mail the Jakarta Activation was also renamed to Angus Activation. Right now Angus Activation is a dependency of the Core Module via Angus Mail. The Outlook Module uses the Outlook Message Parser which still has Jakarta Activation as a dependency, so now I have both Angus and Jakarta Activation as dependencies.

bbottema commented 8 months ago

Good catch. I'll get on it. It's also in java-reflection and as a transitive of jakarta.xml.bind-api

bbottema commented 8 months ago

I got java-reflection sorted out, but jakarta.xml.bind-api 4.x.x -which internally updates to the Angus activation package- requires Java 11. Simple Java Mail is still on Java 8, since in 2023, still a third of all Java usage is Java 8 LTS. This is becoming a challenge.

bbottema commented 8 months ago

Everything sorted out. Update released in 8.6.1.