bbqgophers / qpid

BBQ PID controller written in Go for Raspberry PI
MIT License
78 stars 4 forks source link

Revisit domain types and interfaces #12

Open bketelsen opened 7 years ago

bketelsen commented 7 years ago

make sure the domain types and interfaces in the root package are representing the abstractions we really want/need.

For example, I built the entire app and never once created a qpid.Grill type. So that's not needed. The CookController really is what that Grill type represents. Get rid of un-needed types and interfaces. Make more interfaces or fewer based on needed dependencies.

Probably should not tackle this until more work is done.