Possible incompatibility with 1-2-3 Personalities M1?

[mrfunstuff]

Visual Exceptions identifies an exception between Performance Fish...

"static Boolean CreateInstance_Type.Prefix(Type type, Object&___result)"

and 1-2-3 Personalities M1

"static Patch_ThingWithCompsInitializeComps.Postfix(ThingWithCompsInstance, List'1&___comps"

dunno if this is an actual issue or not!

==

Exception in Verse.ThingWithComps.InitializeComps: System.MissingMethodException: Default constructor not found for type Verse.ThingComp at System.RuntimeType.CreateInstanceMono (System.Boolean nonPublic) [0x0007b] in :0 at System.RuntimeType.CreateInstanceSlow (System.Boolean publicOnly, System.Boolean skipCheckThis, System.Boolean fillCache, System.Threading.StackCrawlMark& stackMark) [0x00009] in :0 at System.RuntimeType.CreateInstanceDefaultCtor (System.Boolean publicOnly, System.Boolean skipCheckThis, System.Boolean fillCache, System.Threading.StackCrawlMark& stackMark) [0x00027] in :0 at System.Activator.CreateInstance (System.Type type, System.Boolean nonPublic) [0x00020] in :0 at System.Activator.CreateInstance (System.Type type) [0x00025] in :0

• prefix bs.performance: Boolean PerformanceFish.System.ReflectionCaching+ActivatorPatches+CreateInstance_Type:Prefix(Type type, Object& __result) at VisualExceptions.ExceptionsAndActivatorHandler+PatchedActivator.CreateInstance (System.Type type, System.Object obj) [0x00009] in <07c490e249c249ff929a9cc5067837e4>:0 at Verse.ThingWithComps.InitializeComps () [0x0003a] in :0
• transpiler net.pardeike.rimworld.lib.harmony: IEnumerable1 VisualExceptions.ExceptionsAndActivatorHandler:Transpiler(IEnumerable1 instructions, MethodBase original)
• postfix hahkethomemah.simplepersonalities: Void SPM1.Patches.Patch_ThingWithComps_InitializeComps:Postfix(ThingWithComps __instance, List`1& ___comps)

[bbradson]

The easy way to test this, as well as any other inconclusive error, is to disable the seemingly involved patch. In this case it would be ReflectionCaching:CreateInstance_Type. After doing so and restarting you will then still get the same error, as it's thrown outside of Fish's patch here, but without any mentions of Fish's no longer running patch. Visual Exceptions generally just guesses based on patches applied somewhere in the stacktrace. It doesn't actually consider their effects or the order they run in, causing it to often be rather wildly inaccurate. Simple Personalities can't possibly be at fault here too, as that mod's patch hasn't even run by the time the error was thrown according to the stacktrace. It's likely caused by a much earlier error, probably a config error or a TypeLoadException somewhere, but has nothing to do with Performance Fish anyway.

[mrfunstuff]

Thank you for the response and explanation, as well as your work on this great tool!