search

bbradson / Performance-Fish

Performance Mod for RimWorld
Mozilla Public License 2.0
423 stars 34 forks source link

Outdated Harmony mod detected. Harmony must be updated for Performance Fish to work correctly #39

Closed Cheremenin closed 2 months ago

Cheremenin commented 2 months ago

Outdated Harmony mod detected. Harmony must be updated for Performance Fish to work correctly UnityEngine.StackTraceUtility:ExtractStackTrace () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Error_Patch1 (string) PerformanceFish.Log/Config/<>c:<.cctor>b12_2 (string) PerformanceFish.Log:Error (FisheryLib.Pools.PooledStringHandler) PerformanceFish.ModCompatibility.ActiveMods:ErrorForOutdatedModDependency (string) PerformanceFish.ModCompatibility.ActiveMods:CheckDependencyVersion (string,System.Type,string) PerformanceFish.ModCompatibility.ActiveMods:CheckHarmonyVersion () PerformanceFish.ModCompatibility.ActiveMods:CheckRequirements () PerformanceFish.Prepatching.FreePatchEntry:Start (Mono.Cecil.ModuleDefinition) System.Reflection.MonoMethod:Invoke (object,System.Reflection.BindingFlags,System.Reflection.Binder,object[],System.Globalization.CultureInfo) System.Reflection.MethodBase:Invoke (object,object[]) Prepatcher.Process.FreePatcher:InvokePatcher (System.Reflection.MethodInfo,Mono.Cecil.ModuleDefinition) Prepatcher.Process.FreePatcher:RunPatches (Prepatcher.Process.AssemblySet,string,System.Action`1) Prepatcher.Process.GameProcessing:Process (Prepatcher.Process.AssemblySet) Prepatcher.Loader:DoReload () Prepatcher.Loader:Reload () Prepatcher.PrepatcherMod:.ctor (Verse.ModContentPack) System.Reflection.MonoCMethod:InternalInvoke (object,object[]) System.Reflection.MonoCMethod:DoInvoke (object,System.Reflection.BindingFlags,System.Reflection.Binder,object[],System.Globalization.CultureInfo) System.Reflection.MonoCMethod:Invoke (System.Reflection.BindingFlags,System.Reflection.Binder,object[],System.Globalization.CultureInfo) System.RuntimeType:CreateInstanceImpl (System.Reflection.BindingFlags,System.Reflection.Binder,object[],System.Globalization.CultureInfo,object[],System.Threading.StackCrawlMark&) System.Activator:CreateInstance (System.Type,System.Reflection.BindingFlags,System.Reflection.Binder,object[],System.Globalization.CultureInfo,object[]) System.Activator:CreateInstance (System.Type,object[]) Verse.LoadedModManager:CreateModClasses () Verse.LoadedModManager:LoadAllActiveMods (bool) Verse.PlayDataLoader:DoPlayLoad () Verse.PlayDataLoader:LoadAllPlayData (bool) Verse.Root/<>c:b__6_1 () Verse.LongEventHandler:RunEventFromAnotherThread (System.Action) Verse.LongEventHandler/<>c:b28_0 () System.Threading.ThreadHelper:ThreadStart_Context (object) System.Threading.ExecutionContext:RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool) System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool) System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object) System.Threading.ThreadHelper:ThreadStart ()

I'm pretty sure I'm using the latest Harmony from Steam. Performance Fish 1.5 version. Is this just some minor oversight that can be safely ignored? No problems otherwise.

P.S. 10 colonists, almost 200 mods, "early midgame" colony. With PF+RocketMan+Performance Optimizer I can get whopping 900 TPS with little no no hiccups, even when large trade caravans arrive, or some other TPS-heavy event occurs! Thank you very much for this mod! Always been a huge fan, downloaded within an hour of the 1.5 release, and it's still amazing as always. Haven't really noticed any compat issues and cross-mod weirdness either, been testing for hours. But not like it's ever been an issue with PF.

Cheremenin commented 2 months ago

Sorry, just noticed that this isn't an issue! https://github.com/bbradson/Performance-Fish/issues/36