Adjust version support in preparation for v2

bbrk24 / lexifer-ts

The code behind the Lexifer web app

https://www.npmjs.com/package/lexifer

MIT License

17 stars 2 forks source link

Adjust version support in preparation for v2 #6

Closed Gravy59 closed 2 months ago

Gravy59 commented 2 months ago

This PR advances #1 by completing two tasks:

Drop support for Node v12, as it reaches end of life soon (2022-04-30)
Upgrade browser requirement to ES2018

bbrk24 commented 2 months ago

I haven't touched this repo in years. I forgot all about #1 . I'm genuinely surprised anyone is doing this.

That being said, by this point the minimum ECMA version could probably be bumped to ES2022 by now. Node 18.0 has basically full support for ES2022 according to https://node.green , and I generally target ES${currentYear-2}.

Edit: I see you put >18.20.2 rather than >=18.12.0. You realize that that excludes all 18.x versions that currently exist, right?

Gravy59 commented 2 months ago

the minimum ECMA version could probably be bumped to ES2022

✅

I see you put >18.20.2 rather than >=18.12.0. You realize that that excludes all 18.x versions that currently exist, right?

I do; that was an unfortunate typo

Thanks!