nus-pe-script
commented
2 weeks ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Person with same name is always considered a duplicate
Two buyer who has the same name, but different phone number and email are considered the same person, when they are clearly not. Rationale for severity: This is of high severity due to how common it is in the real world to share the same name with someone else.
Commands Executed:
buyer n/Test1 p/87654321 e/test@t.ttbuyer n/Test1 p/12345678 e/test1@t.ttExpected Result: The application allows adding the second buyer named Test1
Actual Result:
[original: nus-cs2103-AY2425S1/pe-interim#1812] [original labels: type.FeatureFlaw severity.High]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
We note that this issue could cause an inconvenience to some users as they are unable to add duplicate names with different fields, and thus are unable to add different clients with the same name. Our application has opted for a stricter definition of duplicate clients, and therefore users are unable to add clients of the same name (case insensitive).
However, we do not think that this issue would make the application unusable to most users as they are able to use workarounds such as adding descriptors to the names (i.e. Differentiating between
Alex YeohandAlex Yeoh NUS). Thus, users are still able to use the application albeit with an inconvenience. Hence the severity should be reduced to Medium.Furthermore, we have mentioned this in the User Guide to avoid any confusion for the users.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
People of same name cannot be added
Description
People of same name, for instance, both buyers name Bobby want to buy the property of the agent, they can be differentiated with their different emails and phone number. However, only one Bobby can be added to the addressbook which limits the usage of the addressbook since having same names are very common but system can only store one person per name.
Steps to reproduce
1) launch the app and in the command box, type:
buyer n/Bobby p/91124444 e/bobby123@gmail.com2) first Bobby is added then type command:buyer n/Bobby p/91124443 e/bobby124@gmail.comExpected: a new Bobby contact created with different email and phone number as the first
Actual: Error message: "This buyer already exists in the address book"
This problem is significant as it impedes agents from adding multiple contacts which is very common to see their customers having the same name, and can be differentiated by their phone number and email. However, the app does not support this. Hence, creating flaws to this add contact feature.
This can be improved by checking whether if the number and email already exist, if so, then do not allow duplicate contact to be added rather than using the name as the deciding factor to differentiate different contacts, as phone number and email should not be the same for people.