bbtinkerer / LircNodeJsWeb

Web interface to LIRC using Node.js. Create a universal remote and control your devices from the browser.
GNU General Public License v3.0
52 stars 18 forks source link

fix shell command injection bug #4

Open yakshaver2000 opened 2 years ago

yakshaver2000 commented 2 years ago

An attacker could make the backend process to execute arbitrary shell commands by making requests to URLs containing shell metacharacters.

This commit fixes the vulnerability by replacing a use of "child_process.exec" with "child_process.execFile", which executes "irsend" directly instead of through a shell command.