search

bbusschots / hsxkpasswd

A Perl module and terminal command for generating secure memorable passwords inspired by the fabulous XKCD web comic and Steve Gibson's Password Hay Stacks. This is the library that powers www.xkpasswd.net
http://www.bartb.ie/xkpasswd
BSD 2-Clause "Simplified" License
278 stars 48 forks source link

password generation with named argument 'dictionary_file' #38

Open bjohas opened 5 years ago

bjohas commented 5 years ago

When installing from CPAN, I get:

Failed test 'password generation with named argument 'dictionary_file''

and

Failed test 'password generation with named arguments 'dictionary_file' & 'dictionary_file_encoding''

What could be the problem here? Is my installation incomplete somehow? (OS X)

bbusschots commented 5 years ago

I believe CPAN will terminate the install if a test fails, so I think your install would have been aborted. You can force the installation regardless of test outcomes with the cpan's -f flag.

Tests should not fail though, so it implies something else has gone wrong.

Could you show me the exact command you used to do the install, and, the full output of the install? Also, what exact version of MacOS are you using? And, are you using the default Perl, or Perl from another source like Perl Brew?

bjohas commented 5 years ago

It's the default perl under OS X (10.11.6.)

sudo cpan install Crypt::HSXKPasswd

generates

Running make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00-load.t ................ 1/? # Testing Crypt::HSXKPasswd v3.6, Perl 5.018002, /usr/bin/perl t/00-load.t ................ ok
t/01-defined-constants.t ... ok
t/02-generate-passwords.t .. 1/10

Failed test 'password generation with named argument 'dictionary_file''

at t/02-generate-passwords.t line 35.

Failed test 'password generation with named arguments 'dictionary_file' & 'dictionary_file_encoding''

at t/02-generate-passwords.t line 41.

t/02-generate-passwords.t .. 10/10 # Looks like you failed 2 tests of 10. t/02-generate-passwords.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/10 subtests t/manifest.t ............... skipped: Author tests not required for installation t/perlcritic.t ............. skipped: Author test. Set $ENV{TEST_AUTHOR} to a true value to run. t/pod.t .................... skipped: Author tests not required for installation

(Sorry, don't know how to stop the hash symbol from being interpreted as heading)

bjohas commented 5 years ago

Btw. installation with -f works, and e.g. hsxkpasswd on the commandline seems to give correct results - so perhaps this error doesn't matter?

paultcochrane commented 1 month ago

See also #42 for more information and a link to a patch resolving the issue.