search

bbvillarreal / Codecademy

Codecademy Projects
0 stars 0 forks source link

HTML #2

Open Axkaban opened 6 years ago

Axkaban commented 6 years ago

Great job implementing ids https://github.com/bbvillarreal/Codecademy/blob/master/DasmotosIndex.html#L15

Nice use of span tags with the same class to separate the text in the p tag https://github.com/bbvillarreal/Codecademy/blob/master/DasmotosIndex.html#L34

Good implementation of alt attribute https://github.com/bbvillarreal/Codecademy/blob/master/DasmotosIndex.html#L29

I would suggest two things, one, start implementing comments throughout your file to separate sections, it will make it easier for you to navigate when your file size is 100+ lines, and two, start practicing saving your css file in a css directory inside a resources directory, as well as saving the images locally in an images directory inside of that resources directory, that way you will not be depending on third party sites or cloud storage.

bbvillarreal commented 6 years ago

Axkaban,

Thanks for the suggestions. They are appreciated. I will implement them from now on and will re-design the folder structure for this project now.

Thanks!