hw07 ready for grading

[bcahn7]

hw07 ready for grading

[qiaoyuet]

Peer Review:

Report:

• The topic is very interesting!
• The plot of the stock price is nicely done, except maybe the title and legends font can be a bit larger?
• The green color for amazon's stock price plot is a bit hard to see, or if you increase the width of the line by setting lwd=a larger number.
• Good to know the summarize_each() function.
• You used a lot of terminologies like risk free rate which I didn't quite understand, but your function looks well written.
• I guess gsub() is just an alternative to str_replace()?
• Not sure why you want to write a function for ret_func(). It looks to me if you just substitute x with mkt_data and use all the pipelines defined in this function then it'll work.
• The linear regression line seems to capture the positive relationship between market return and apple/amazon return.
• Good to read the explanations about the regression lines.

Scripts and makefile:

• For all, I think you can just put 03_report.md because the other .png plots are included in the report file.
• Good to use the regular expression in *.png. I should use this too:)
• Overall very well written.

[vibudh2209]

Hi Its great to see someone using some other data here and its a really great homework.

• More than 3 Rscript made and pipelined together
• Did the analysis on "not gapminder" data (Great!!!)
• Constructed make, clean, master r files to run the rest of the scripts
• Explained properly each step in the pipeline
• Repo is easy to go through
• All the links work and and reported the progress

Few comments:

• Great work with plotting and calculating price performances for each company, one suggestion can be that instead of saving in csv format you may want to save in RDS if you want to preserve some ordering in your data. The plot axis titles, titles and legends can be little bigger in font. For a non finance background guy like me I really liked going through all the comparisons.
• In you 02_cum_ret_plot.R script I did not understand why you saved cum_rets_gathered.csv file which you used for plotting, I mean I don't see you using it anywhere else. I just feel that this part of the code could be inserted in your 01_calculate-ret.R file. But anyway everyone have there ways of doing things but you explained everything very neatly and presented it pretty well.
• Maybe instead of doing regression analysis on markdown you could have done it in some rscript and sent that regression file to markdown from which you could have directly read the coefficients. Still your analysis again is very clear and not so difficult to understand.

Overall with little bit effort I was able to understand your work without having any background so its clear you explained everything very well and piped everything very efficiently so overall its great work, its a very well done homework (keep it up!!!)

Cheers Vibudh

[derekcho]

Hi @bcahn7 ! Here are some comments about your hw07:

Three or more scripts, an Rmd, and a Makefile: Yes Starts by downloading data, ends with Rmd: Yes The output of each is the modified input of the previous step: Yes Includes some analysis and at least one figure: Yes Makefile includes all scripts and Rmd with correct dependencies: No (see comments) Makefile runs: Yes

• Good job getting your Makefile to run. I was able to download your code onto my computer and generate your report without any hassle!
• I have a few small concerns about your Makefile, even though it runs without errors as is. First of all, you can group your outputs together into a single block since they have the same dependencies and use the same script even though they are of different file types (ex. hw07_cum_ret.png and cum_rets_gathered.csv). 03_report.md does not have the correct dependencies since it also relies on hw07_AAPL_prc.png hw07_AMZN_prc.png which are embedded directly in your report.
• Nice work with the exploratory analysis, you produced some excellent plots and provided relevant summary statistics as well. Your statistical analysis and data cleaning were also well done! You provided good explanations and interpretations of your results as well.
• You used your own dataset for this assignment and chose a very interesting one! You also embedded graphics into your report.
• Overall, nice work! You did a pretty good job getting make to work with your pipeline except for a few dependency errors.

Note: your mark (check minus, check, check plus) will be distributed later.