Open bcahn7 opened 6 years ago
Hi @bcahn7
Your app has great functionality and is easy to use.
All the filtering options seem to be working as intended. The download link is also working properly and provides the filtered data. I liked how you gave the user the option to open an additional filter by subtype. By keeping this option initially hidden, it reduced cluttering.
Putting the plot and table on separate tabs also helped with the organization. The picture was a nice touch too.
If you wanted to improve this further, I would suggest playing around with the design. For example a large, colorful title, and different fonts. This could be done using shinyjs
and CSS
. I also found shinythemes
to be a very easy way to spice things up. All that is required is the line theme = shinytheme("journal")
in the UI
. Additionally you could try showing off some of your ggplot2
skills!
Your readme file does a great job explaining your workflow. Also your code looks very good, though it would have been easier to follow if you added more comments.
Also really liked that your plot did not break when the data was filtered to zero entries by using if(is.null())
. I couldn't figure out how to do this!
Cheers, Sep
Hello bcahn7,
You completed a solid submission that met many of the recommendations for app development. Your readme file was easy to navigate and identified what features you added, including the use of an image, a reactive table presented in a new tab, and the option to download table results. Your code was also legible and could be followed through.
One feature that could be considered for the app is the use of shading or color to differentiate results that reflect different alcohol types. For instance, currently if one selects beer and spirits, there is not set way to differentiate portion of the figure reflects which alcohol type. A smaller addition would be whether the X or Y axis of your plot might be modified. This would allow "Alcohol Content" rather than "Alcohol_Content" and something like "Frequency" rather than "Count". Although this is more of an aesthetic preference.
Hi @bcahn7, here are some comments about your hw08:
App split into ui.R and server.R: Yes Deployed on shinyapps.io: Yes Repo has code and README: Yes Number of features implemented: 11 Progress report: Yes
Your grade will be emailed to you at a later date.
hw08 ready for grading