hw09 ready for grading

[bcahn7]

hw09 ready for grading

[xinmiaow]

Hi @bcahn7,

It’s nice to review your package. I did not choose this task, so it’s good for me to learn from your homework.

You create the following functions in your powers Package:

Export Functions

• [X] square:
  • square of a vector (numerical or logical elements)
  • plot the result by ggplot
  • deal with NA by na.omit
• [X] cube:
  • cube of a vector (numerical or logical elements)
  • plot the result by ggplot
  • deal with NA by na.omit
• [X] four
  • fourth power of a vector (numerical or logical elements)
  • plot the result by ggplot
  • deal with NA by na.omit
• [X] reciprocal
  • reciprocal of a vector (numerical or logical elements)
  • plot the result by ggplot
  • deal with NA by na.omit
• [X] boxcoxt
  • take the box cox transformation of a vector of numerical values

Each function is documented and has the corresponding test file. I notice one typo in your document of boxcoxt. You put y inside boxcoxt, but the argument explain what x is. I think these two symbols are supposed to be consistent.

Internal Functions

• [X] pow
  • calculate the power of a vector
  • plot the result

Other files:

• [X] README file
• [X] Vignettes file
• [X] Description
  • Import ggplot
  • no licenses!!!

Overall, I think you did good job.

[yidie]

Hi @bcahn7 , here are some comments:

• Vignettes and README are easy to follow and understand what the package does and what each function does.

• pow() This function generates a plot of the power of numbers, which is used in your square() and reciprocal() functions. Good job!

• square(), reciprocal(), four(), cube() Besides returning the square/reciprocal/cubic power/fourth power of the number. They also give a plot if plot_it=T via pow() function. It is very nice that you include the option for omitting NA's or not. And you set default values to these arguments. All the functions are documented properly. Each function has three unit tests: one for numeric vector, one for logical vector and one for character vector.

• boxcoxt() Good use of nested if...else... statements to check the validity of lambda. Warning messages are informative as well. It is documented properly. There are four unit tests: one for success, one for negative input (failure), one for character input (failure) and one for warning message.

• Overall, I think you did a good job. Reflections are also good.

Yidie

[derekcho]

Hi @bcahn7, here are some comments about your hw09:

Able to install properly: Yes At least one new function: Yes Used assertions to check function input: No Documented exported functions: Yes Includes three unit tests for each function: Yes Passes check: Yes README and vignette: Yes Reflections included: Yes

• Nice work on this assignment. Your package installs without any issues.
• Your functions are well documented and worked as described in the vignette when I tested them
• However, your functions lack any kind of error testing
• Good README file that provides a good description of the package and its functions

Your grade will be emailed to you at a later date.