🐛 [BUG]: The connect bug on the basic example page

zzc-1024 commented 2 weeks ago

Is there an existing issue for this?

[X] I have searched the existing issues and this is a new bug.

Current Behavior

When I connect two nodes of the same handle type which is incorrect, it automatically changes the handle of the node connection.
The order of Handle connections will affect whether the connection can be successful.

Expected Behavior

When the user is connected incorrectly, the connection should be rejected.
Whether the connection is successful or not should be independent of the connection order.

Steps To Reproduce

website

https://github.com/user-attachments/assets/9d578144-88e1-451d-b6ef-1e19142a2db5

https://github.com/user-attachments/assets/01e9e379-b5c1-4c22-a15a-48ca4b84daa1

Relevant log output

No response

Anything else?

No response

bcakmakoglu commented 1 week ago

Thanks for the report. I’ll take a look once I’m back from vacation 👍

bcakmakoglu commented 1 week ago

What happens here is that with ConnectionMode.Loose (which is currently the default, although with 2.0 ConnectionMode.Strict will be the default mode) allows source <--> source and target <--> target connections but this requires handles to have a fixed id, otherwise VueFlow has to assume that the handle types that should be used are source <--> target (since the ids are null by default).

It's not great atm but a fix for this would be a breaking change, thus this will be fixed in 2.0 and not in any of the next patch/minor releases, sorry.

I'll keep this issue open to track it for the next major release though.

zzc-1024 commented 1 week ago

Thank you for your patient answer.😃

bcakmakoglu / vue-flow