search

bcalden / ClusterPyXT

The Galaxy Cluster ‘Pypeline’ for X-ray Temperature Maps
BSD 3-Clause "New" or "Revised" License
27 stars 8 forks source link

Allow for ACIS-S observations in pipeline #5

Closed bcalden closed 1 year ago

bcalden commented 5 years ago

The pipeline should allow for the inclusion of ACIS-S observations within the pipeline.

granttremblay commented 2 years ago

Hi Brian!

Any progress on this? I'm happy to try to hack together an ACIS-S enhancement using your dev-ciao-4.13 branch, if you'd like. But I don't want to replicate work you're already doing!

bcalden commented 2 years ago

Hi Grant!

There is some progress on this issue. Definitely not ready for release and lots of naming issues still exist (generated files named acisI.fits instead of acisS.fits). However, ACIS-S observations can be processed through the dev 4.13 pipeline as it stands. I just processed A545, OBSID 13998 to test and it appeared to produce a reasonable temperature/pressure map. I have not tried a mixed ACIS-I and ACIS-S observation but am glad to actively help navigate through the code if there are any issues that arise.

granttremblay commented 2 years ago

Thank you Brian! Just to be absolutely clear as we test this on ACIS-S observations: all region files the user creates should be in ciao format and physical coordinates, with the exception of master_crop-ciaowcs.reg (which should be in ciao format with wcs coordinates). Correct?

bcalden commented 2 years ago

My first response was going to be yes until I went through a cluster real quick to check how I do it. Every cluster I have processed lately used wcs coordinates in ds9 format for all region files. I don't want to say there are no formatting restrictions anymore, but I think the ciao/ds9 and physical/wcs coordinate rigidity is a vestige of older code.

To be explicit about it, my sources.reg, exclude.reg, master_crop-ciaowcs.reg, and acisI_region_0.reg are all in ds9 format with wcs coordinates.

If this does not work on your end please let me know and I will attempt to track down the issue.