Fail loudly when `type` is misspecified

bcallaway11 / did

Difference in Differences with Multiple Periods, website: https://bcallaway11.github.io/did

298 stars 95 forks source link

Fail loudly when `type` is misspecified #122

Closed kylebutts closed 2 years ago

kylebutts commented 2 years ago

The below code doesn't give any warning or indication of failure. Instead silently returning NULL

library(did)
data(mpdta)
out <- att_gt(yname="lemp",
              tname="year",
              idname="countyreal",
              gname="first.treat",
              xformla=NULL,
              data=mpdta)

aggte(out, type = "simpl")

^{Created on 2022-03-29 by the reprex package (v2.0.1)}

kylebutts commented 2 years ago

I think the R-CMD-check is failing because of honest_did, not my edit!