bcallaway11 / did

Difference in Differences with Multiple Periods, website: https://bcallaway11.github.io/did
288 stars 92 forks source link

[bug] unused argument (balance_panel = FALSE) while running att_gt function #92

Closed filipemsc closed 2 years ago

filipemsc commented 2 years ago

I just installed the new version of the did package (2.1) and obtained the following error while trying to run a simple code with it:

library(did)
#> Warning: package 'did' was built under R version 4.1.2
data(mpdta)

out1 <- att_gt(yname="lemp",
               tname="year",
               idname="countyreal",
               gname="first.treat",
               xformla=NULL,
               data=mpdta)
#> Error in BMisc::panel2cs2(disdat, yname, idname, tname, balance_panel = FALSE): unused argument (balance_panel = FALSE)
pedrohcgs commented 2 years ago

Could you also update the BMisc package? That should do it.

Thanks

Pedro H. C. Sant'Anna Department of Economics Vanderbilt University 615-875-8448 (phone) @.*** https://email.vanderbilt.edu/owa/redir.aspx?SURL=R33SAibMcqASxYI7tVlx3_2Xx09NkN6m1ZKVuyK8lL42lUjfQp_SCG0AYQBpAGwAdABvADoAcABlAGQAcgBvAC4AaAAuAHMAYQBuAHQAYQBuAG4AYQBAAHYAYQBuAGQAZQByAGIAaQBsAHQALgBlAGQAdQA.&URL=mailto%3apedro.h.santanna%40vanderbilt.edu https://pedrohcgs.github.io

On Thu, Dec 16, 2021 at 2:40 PM Filipe Cavalcanti @.***> wrote:

I just installed the new version of the did package (2.1) and obtained the following error while trying to run a simple code with it:

library(did)

> Warning: package 'did' was built under R version 4.1.2

data(mpdta)

out1 <- att_gt(yname="lemp", tname="year", idname="countyreal", gname="first.treat", xformla=NULL, data=mpdta)

> Error in BMisc::panel2cs2(disdat, yname, idname, tname, balance_panel = FALSE): unused argument (balance_panel = FALSE)

— Reply to this email directly, view it on GitHub https://github.com/bcallaway11/did/issues/92, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABE7342DT2MLEBPNGU4Y3RDURJFFDANCNFSM5KHH7QDQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

filipemsc commented 2 years ago

Worked! Thanks