search

bcardarella / valid_attribute

Minimalist validation BDD for ActiveModel specs
178 stars 18 forks source link

silence RSpec 3 warnings #33

Closed se3000 closed 10 years ago

se3000 commented 10 years ago

Covers all the RSpec 3 warnings I've seen. Some were just regular Ruby warnings, but RSpec 3 is especially loud about them by default.

I left the old negative rspec matcher too. I can get rid of it if you have a preferred method for handling different versions of libraries.

bcardarella commented 10 years ago

Are these warnings about the instance variables not being defined?

se3000 commented 10 years ago

The change on line 8 is about instance variables not being defined.

There was another warning because the attr_reader for @values was being redefined.

The loudest error is that #negative_failure_message is a legacy matcher, replaced by #failure_message_when_negated. That is the only one that still goes off if you turn RSpec's warnings output off.

bcardarella commented 10 years ago

:+1:

Let me look into why Travis is failing before merging this in. I don't think your PR is causing those failures.

aaronchi commented 10 years ago

Seems to be a gem dependency issue with loading minitest

m5rk commented 10 years ago

I should have looked at the existing pull requests before opening #34. I'm going to close that now that I've seen this one. Any update on the Travis issue?

ultrasaurus commented 10 years ago

Travis looks like it is passing now. It would be awesome if this could be merged in!

bcardarella commented 10 years ago

I just released 2.0.0 which includes these changes

ultrasaurus commented 10 years ago

Lovely. Thanks so much!