search

bcardarella / valid_attribute

Minimalist validation BDD for ActiveModel specs
178 stars 18 forks source link

Better descriptions #9

Closed AndrewRadev closed 13 years ago

AndrewRadev commented 13 years ago

Hello, Brian,

I've changed the description a bit, because it didn't clearly show what attribute was being spec'd. For example:

describe Something
  it { should.have_valid(:name).when(:abc, 123) }
end

The message in this case looks something like:

Something
  should be valid when: "abc", 123

I'd definitely prefer to see this instead:

Something
  should be valid when name is: "abc", 123
bcardarella commented 13 years ago

Good call, pulled in. Thanks!

I'll release a new version tonight.