bcardiff / crystal-fswatch

MIT License
16 stars 2 forks source link

Update libfswatch version to 1.16 #3

Closed paulocoghi closed 2 years ago

paulocoghi commented 2 years ago
paulocoghi commented 2 years ago

Sorry. Now I saw important Linux distro releases, including Ubuntu 20.04 LTS (22.04 is still in beta), providing fswatch 1.14 and to be able to use more recent versions the developer would need to compile it from source.

I vote to close my PR :smile:

bcardiff commented 2 years ago

The version "requirement" for the library is only informational. It's not enforced. Yet ~> 1.14 means that 1.16 should be supported.

Now the Crystal version is checked and since 1.0 it will cause a warning having the crystal version be 0.x.

So, it make sense to bump the crystal version to 1.0.0. And release a new version of the shard to avoid the warning. And maybe some docs improvements if needed.

These are not blocker issues so we can see what else would be needed for a better experience for future users given that you are experiencing with it :-)

paulocoghi commented 2 years ago

Agree. Closing this one to avoid changing minimal Crystal version without the other important steps you mentioned, like docs improvement.