search

bcardiff / docker-rclone

Docker image to use rclone to run cron sync with monitoring
https://hub.docker.com/r/bcardiff/rclone
MIT License
78 stars 60 forks source link

Make ARCH and RCLONE_VERSION build-time arguments #5

Closed danny-cheung closed 5 years ago

danny-cheung commented 5 years ago

This is so that you can override the variables at build time. They are currently not used anywhere else.

pfidr34 commented 5 years ago

Hi, I have updated this project to the most current version of rclone and built build time arguments into my project.

https://hub.docker.com/r/pfidr/rclone https://github.com/pfidr34/docker-rclone

bcardiff commented 5 years ago

Thanks @danny-cheung

pfidr34 commented 5 years ago

Heads up on this PR. Your Dockerfile is now broken.

If someone passes v1.45 as the RCLONE_VERSION line 20 will fail.

wget -q http://downloads.rclone.org/rclone-${RCLONE_VERSION}-linux-${ARCH}.zip

http://downloads.rclone.org/rclone-v1.45-linux-amd64.zip is not a valid URL and build will fail.

See my Dockerfile or take PR #8 to get this fixed.

pfidr34 commented 5 years ago

Also, looks like you have auto build turned on for Docker Hub, so this is also already pushed to and broken there as well.

bcardiff commented 5 years ago

ok, I will take a look at that. The #8 PR has many changes to merge them directly I will probably extract some of them. I don't want to make you split them :-)