search

bcbi / ClassImbalance.jl

Sampling-based methods for correcting for class imbalance in two-category classification problems
Other
11 stars 9 forks source link

Update for DataFrames.jl 0.11+ #3

Closed DilumAluthge closed 6 years ago

DilumAluthge commented 6 years ago

@paulstey This PR updates ClassImbalance.jl to work with DataFrames.jl 0.11+.

paulstey commented 6 years ago

Hi @dilumaluthge,

Could you write some tests for this? I know this is a minor change, but nonetheless, it's good practice.

-Paul

DilumAluthge commented 6 years ago

Can do!

On Wed, Jan 24, 2018 at 11:25 Paul Stey notifications@github.com wrote:

Hi @dilumaluthge https://github.com/dilumaluthge,

Could you write some tests for this? I know this is a minor change, but nonetheless, it's good practice.

-Paul

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bcbi/ClassImbalance.jl/pull/3#issuecomment-360190194, or mute the thread https://github.com/notifications/unsubscribe-auth/AFXArYjCCSeGg-yOmRI36v8eeunsH7gjks5tN1mOgaJpZM4RRP8g .

-- Sent from Gmail Mobile

DilumAluthge commented 6 years ago

Hi @paulstey the tests now all pass on my local machine. Travis isn't set up for this repo.

paulstey commented 6 years ago

Thanks, Dilum!