search

bcbi / ClassImbalance.jl

Sampling-based methods for correcting for class imbalance in two-category classification problems
Other
11 stars 9 forks source link

add RandomUnderSampling functionality #89

Open vmpyr opened 1 year ago

vmpyr commented 1 year ago

Work underway. Have added functions to utils for future use as well

DilumAluthge commented 1 year ago

Just a quick comment.

This package hasn't been updated in a while, so the CI in this repo is Travis CI. Of course, Travis CI no longer offers free CI for open source projects. So we need to migrate the CI to GitHub Actions CI.

@vmpyr @AshlinHarris Would you two be willing to work together to migrate CI to GitHub Actions? You can use https://discourse.julialang.org/t/easy-workflow-file-for-setting-up-github-actions-ci-for-your-julia-package/49765 as a starting point.

AshlinHarris commented 1 year ago

@DilumAluthge Could you please add me as an admin on this repo? I can't access the branch protection, but I'll probably need to remove the travis-ci requirement.

DilumAluthge commented 1 year ago

Done.

DilumAluthge commented 1 year ago

If possible, I'd recommend doing the Travis-to-GitHub-Actions migration in a separate PR. I tend to prefer multiple smaller PRs (instead of one large PR), because I find that the smaller PRs are each easier to review.

vmpyr commented 1 year ago

@AshlinHarris

I'm guessing that 100% codecov is a required test. Do you have test cases for each option?

Not as of now, I have written the functionality and will start writing the tests today most probably.

DilumAluthge commented 1 year ago

Yeah, we should keep the requirement of having 100% code coverage.

vmpyr commented 1 year ago

@DilumAluthge

If possible, I'd recommend doing the Travis-to-GitHub-Actions migration in a separate PR.

Yes, I'll happily work on that. Will I be needed to have admin privileges as well? If so, please add me as admin too.

The repo needs a huge overhaul since it is very old now.

DilumAluthge commented 1 year ago

It'll be sufficient for @AshlinHarris to have admin permissions; there are relatively few settings that need to be modified.