search

bcbi / DeIdentification.jl

A Julia package for de-identifying CSV data sets
https://bcbi.github.io/DeIdentification.jl/latest/
MIT License
2 stars 1 forks source link

Add the ability to generate configs from CSV files #35

Closed ibacher closed 5 years ago

ibacher commented 5 years ago

Also generates random seeds where approriate

bors[bot] commented 5 years ago

Build failed

ibacher commented 5 years ago

bors r+

bors[bot] commented 5 years ago

Build failed

DilumAluthge commented 5 years ago

@ibacher You can drop support for Julia 0.7 if you want.

ibacher commented 5 years ago

Yeah, was just thinking I would do that… Might roll them over to Julia 1.1 though.

On Jul 15, 2019, at 4:08 PM, Dilum Aluthge notifications@github.com wrote:

@ibacher https://github.com/ibacher You can drop support for Julia 0.7 if you want.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bcbi/DeIdentification.jl/pull/35?email_source=notifications&email_token=AMQSM2UD3PRFMAIMSW7PVVDP7TKKTA5CNFSM4ID2GBTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ62E6I#issuecomment-511550073, or mute the thread https://github.com/notifications/unsubscribe-auth/AMQSM2TCAEDVGOOOSB4RG6TP7TKKTANCNFSM4ID2GBTA.

DilumAluthge commented 5 years ago

I wouldn’t drop support for both 0.7 and 1.0 at the same time. Generally the Julia General Registry maintainers don’t like it when you drop support for more than one version of Julia in a single release.

I’d recommend the following sequence of events:

  1. Drop support for 0.7 and merge this PR,
  2. Bump the major component of the version number in Project.toml.
  3. Make a new release with Registrator (https://github.com/JuliaRegistries/Registrator.jl)
  4. Drop support for 1.0.
  5. Bump the major version number again.
  6. Make another release with Registrator
ibacher commented 5 years ago

Oh no! To be clear, I wasn't going to drop 1.0. I was just going to add testing against 1.1!

DilumAluthge commented 5 years ago

Ahhhh I see. Yes that’s a good idea!

DilumAluthge commented 5 years ago

You can also add “1.2”. It’ll point to the release candidate.

DilumAluthge commented 5 years ago

Bors r+

bors[bot] commented 5 years ago

Build succeeded