bcbio / bcbio-nextgen-vm

Run bcbio-nextgen genomic sequencing analyses using isolated containers and virtual machines
MIT License
65 stars 17 forks source link

boto ec2.import_key_pair expects bytes, not a str #180

Closed cariaso closed 4 years ago

cariaso commented 4 years ago

This a small change that could maintain backwards compat while fixing the bug. It could instead not do the failing call, and instead always do the .encode('utf-8'), but perhaps that would be an issue for py27 support?

chapmanb commented 4 years ago

Mike -- thanks much for the fix. I'm a bit worried there are going to be quite a few of these as this hasn't gotten a complete py3k overhaul and improvement, but happy to at least be getting a few of them checked off. Thank you again for looking at this.