Allow passing in arbitrary parameters to rofi

bcbnz / python-rofi

A Python module to make simple GUIs with Rofi

MIT License

111 stars 20 forks source link

Allow passing in arbitrary parameters to rofi #9

Closed mpardalos closed 6 years ago

mpardalos commented 6 years ago

This can be done in two ways:

Pass in the other_args parameter to the Rofi constructor. The arguments are then appended to every call to rofi (through the Rofi._common_args method).
Pass in other_args to the method calls on the Rofi object which launch rofi. These are appended after all other arguments (including the ones passed in the constructor)

Addresses #4

bcbnz commented 6 years ago

Thanks for the request! This works well, just a couple of comments:

I think rofi_args is more descriptive than other_args for the parameter name.
A couple of usage examples would be good. The main thing is that parameters with arguments need to be given as two separate items, i.e., other_args=['monitor 0'] has no effect -- it needs to be other_args=['monitor', '0']. Also, worth noting that all arguments need to be strings as other_args=['monitor', 0] will result in a TypeError from the subprocess module.

bcbnz commented 6 years ago

Awesome, thanks. Merged and I'll try to address the current issues and get an update onto PyPI within the next week.

mpardalos commented 6 years ago

Perfect. Thanks a lot!

On Sat, 30 Jun 2018, 12:39 Blair Bonnett, notifications@github.com wrote:

Awesome, thanks. Merged and I'll try to address the current issues and get an update onto PyPI within the next week.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bcbnz/python-rofi/pull/9#issuecomment-401530062, or mute the thread https://github.com/notifications/unsubscribe-auth/ACZWPqHy64GqsE-FTtwc4Wlz66ZhNSmaks5uB0dhgaJpZM4Uq13T .