bcc-code / bcc-design

Packages, assets and documentation to use the BCC Design System

https://developer.bcc.no/bcc-design

Apache License 2.0

3 stars 5 forks source link

feat: improve Shadow DOM compatibility #264

Closed Bernton closed 8 months ago

Bernton commented 8 months ago

Change summary

Add :host to make library compatible with Shadow DOM. This was also done in tailwindcss recently: https://github.com/tailwindlabs/tailwindcss/pull/11200

Change type

[ ] No review
[x] Small PR
[ ] Big PR
[ ] Refactor

Regarding: https://github.com/bcc-code/bcc-platform/issues/122

github-actions[bot] commented 8 months ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-coast-028fe6203-264.westeurope.3.azurestaticapps.net

Bernton commented 8 months ago

@laurensgroeneveld can you add it to the latest stable aswell? 1.8.1 or something like this? Since it's not a breaking change.

laurensgroeneveld commented 8 months ago

Unfortunately we don't have a mechanic currently to update older releases... It should be fairly straightforward though to update to the 2.0 beta, especially if you don't extensively use the typography styles

Bernton commented 8 months ago

@laurensgroeneveld this really should be established, what if you have a critical bug in 1.8.0, and you want to patch it without forcing everyone to switch to the v2 beta?