bcc-code / bcc-design

Packages, assets and documentation to use the BCC Design System
https://developer.bcc.no/bcc-design
Apache License 2.0
3 stars 5 forks source link

BccPagination #300

Closed starkris51 closed 2 months ago

starkris51 commented 3 months ago

Change summary

Added BccPagination

Change type

Closes #ISSUE_NUMBER or Part of #ISSUE_NUMBER

starkris51 commented 3 months ago

@laurensgroeneveld Kunne du sjekke denne?

starkris51 commented 2 months ago

@laurensgroeneveld i'm wondering about if the Table in pagination storybook should be kept or removed like with the Radix Vue version where i only show the component itself.

laurensgroeneveld commented 2 months ago

@laurensgroeneveld i'm wondering about if the Table in pagination storybook should be kept or removed like with the Radix Vue version where i only show the component itself.

I think that's fine, then when we add pagination support to the Table component itself it can instead be shown there.

I didn't add a comment on it before, but you could even add a few stories showing some different options at a glance, like if you hide the page selector, alignment etc.

starkris51 commented 2 months ago

@laurensgroeneveld i'm wondering about if the Table in pagination storybook should be kept or removed like with the Radix Vue version where i only show the component itself.

I think that's fine, then when we add pagination support to the Table component itself it can instead be shown there.

I didn't add a comment on it before, but you could even add a few stories showing some different options at a glance, like if you hide the page selector, alignment etc.

I've moved the table as a story instead.