bcc-code / bcc-design

Packages, assets and documentation to use the BCC Design System

https://developer.bcc.no/bcc-design

Apache License 2.0

3 stars 5 forks source link

BccPagination (Radix Vue) #301

Closed starkris51 closed 1 month ago

starkris51 commented 2 months ago

Change summary

Alternative component to the other BccPagination made from scratch, using Radix Vue.

Change type

[ ] No review
[ ] Big PR
[ ] Small PR
[ ] Refactor

Closes #ISSUE_NUMBER or Part of #ISSUE_NUMBER

starkris51 commented 2 months ago

@laurensgroeneveld i've remade the component using Redix Vue, can you try compare both of them.

starkris51 commented 2 months ago

i know this might not be merged but this version of the component has better functionality and more user friendly, the radix version is easier to switch pages with since it replaces buttons while my version adds buttons making it longer, just keep that in mind.

starkris51 commented 2 months ago

Should we close this pull request or just keep it?

laurensgroeneveld commented 2 months ago

Should we close this pull request or just keep it?

Maybe you can check my comment on introducing Radix as a dependency? If that's avoidable (as I think it should, we also use HeadlessUI which is also a devDependency) I would be fine with merging it.

laurensgroeneveld commented 1 month ago

Closing this so it frees up an Azure deploy preview slot (as I can't access Azure to clean it up 😅). Feel free to reopen if this becomes relevant again if we want to move in this direction.