search

bcc-code / bcc-media-app

[BCC Media] Video-on-demand app for iOS and Android
https://apps.apple.com/no/app/brunstadtv/id913268220
Apache License 2.0
16 stars 3 forks source link

Fix tabs analytics for kids #246

Closed andreasgangso closed 1 year ago

andreasgangso commented 1 year ago

We are sending a screen() event when switching tabs. The implementation was based on a hardcoded assumption that the tabs was in this order: home, search, livestream, calendar.

So when we now have "home, games, search" on biblekids, it's actually sending "search" when it's supposed to be "games". And "livestream" means "search".

The code here needs to be fixed so that it works with our dynamic tab setup.

andreasgangso commented 1 year ago

I'd say 1 story point, but I guess I'm not allowed to add story points outside sprint planning?

andreasgangso commented 1 year ago

Fixed by https://github.com/bcc-code/bcc-media-app/commit/83d797bc091dcfdecec9824a1f44ed7a785fef09 v4.9.2